Add hash to point from RFC9380 #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K1li4nL
force-pushed
the
kilian-add-hash-to-ed
branch
from
fc565eb to
c04199d
Compare
AnomalRoil
requested changes
May 6, 2024
| return dst, nil | ||
| } | ||
|
|
||
| func curve25519Elligator2(u fieldElement) (xn, xd, yn, yd fieldElement) { |
There was a problem hiding this comment.
Can't this also be used for Curve25519? Why put it in Edwards25519?
There was a problem hiding this comment.
Yes it can, though our Curve25519 doesn't use fieldElement but only big.Int, it would make sense to put it there but it would be of no use unfortunately.
AnomalRoil
reviewed
May 6, 2024
K1li4nL
force-pushed
the
kilian-add-hash-to-ed
branch
from
49ec0f3 to
3275d0b
Compare
K1li4nL
force-pushed
the
kilian-add-hash-to-ed
branch
from
3275d0b to
45763cc
Compare
AnomalRoil
reviewed
May 10, 2024
si-co
reviewed
Jun 3, 2024
K1li4nL
force-pushed
the
kilian-add-hash-to-ed
branch
from
9b8b1a8 to
8b5d5fe
Compare
|
K1li4nL
force-pushed
the
kilian-add-hash-to-ed
branch
from
c17b790 to
a607602
Compare
azixus
suggested changes
Jun 12, 2024
|
azixus
approved these changes
Jun 13, 2024
AnomalRoil
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Hash() on Ed25519